oracle-actions / setup-java

GitHub Action to download and install Oracle's Java Development Kit builds
Universal Permissive License v1.0
62 stars 11 forks source link

Support running action with ARM64 machines #64

Closed vlsi closed 7 months ago

vlsi commented 9 months ago

Try JAVA_HOME_17_ARM64 first, and fallback to JAVA_HOME_17_X86

Fixes https://github.com/oracle-actions/setup-java/issues/63

oracle-contributor-agreement[bot] commented 9 months ago

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA). The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

vlsi commented 9 months ago

@sormuras it looks like I forgot to include my GitHub username when filing CLA. Do you think you could help me with adding my GitHub id to the Oracle CLA?

Here's my OpenJDK id: https://openjdk.org/census#vsitnikov

https://oca.opensource.oracle.com/?ojr=faq Why should I provide my GitHub username in the OCA? ... If you forgot to put your GitHub username on the OCA when filing it, please reach out to project maintainers (e.g., through comments on your GitHub PR, Slack channels, or mailing lists) who can add it for you.

sormuras commented 9 months ago

Hi Vladimir, I started the runs and also asked (how) to connect your GH username to CLA - let's wait and see what happens.

robilad commented 9 months ago

Hi, in order to get your account verified, please send me an e-mail directly at dalibor.topic@oracle.com

sormuras commented 9 months ago

Any news on the OCA here?

sormuras commented 9 months ago

I skimmed https://github.com/actions/runner-images#available-images and found only an ARM architecture mentioned here: https://github.com/actions/runner-images/blob/main/images/macos/macos-13-arm64-Readme.md#java as for example JAVA_HOME_17_arm64

Note: it ends with a lower-case arm64.

vlsi commented 9 months ago

See also: https://github.com/actions/setup-java/issues/561

sureshg commented 7 months ago

Can we merge this change as M1 mac runner is available for general public now?

sormuras commented 7 months ago

This PR and your PR #71 lack an OCA approval. I'll talk to @robilad how to follow-up on this.