search

oracle-actions / setup-java

GitHub Action to download and install Oracle's Java Development Kit builds
Universal Permissive License v1.0
62 stars 11 forks source link

Feat: Add support for M1 MAC runners #71

Closed sureshg closed 7 months ago

sureshg commented 7 months ago

Github action recently added support for MacOS M1 runner (https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/) and is free for public repos. Since the action script hardcoded JAVA_HOME for x86 arch, tit won't run on ARM64 machines. This PR will fix that.

oracle-contributor-agreement[bot] commented 7 months ago

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA). The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

sormuras commented 7 months ago

Duplicate of PR https://github.com/oracle-actions/setup-java/pull/64?

sureshg commented 7 months ago

@sormuras yeah it's the same. But shouldn't we need to change other workflows too where we are accessing JAVA_HOME and runs-on multiple runners? Feel free to close this if you are planning to merge the other PR.