search

oracle-samples / clara-rules

Forward-chaining rules in Clojure(Script)
http://www.clara-rules.org
Apache License 2.0
1.19k stars 111 forks source link

Support of clojure.spec and clojure 1.9 #221

Open ghost opened 8 years ago

ghost commented 8 years ago

Hi Ryan,

just to let you know that I am working on getting Clara to compile under 1.9-alpha11. I added an AOT profile and upgraded clojure and other deps to 1.9. Been fixing minor issues. Now the net is dying here, I will resume this tomorrow. You can expect a pull request by next Monday/Tuesday.

Meanwhile if I can fix it, I'll maintain my own version aside until you find some time to merge these mods.

rbrush commented 8 years ago

Sounds great, Luc! We'll probably want to wait until 1.9 is released before merging to master, but having this ready in a branch we can can merge with 1.9 drops would definitely be nice.

bfontaine commented 8 years ago

FWIW I’m able to use Clara under 1.9-alpha12 without any apparent issue.

ghost commented 8 years ago

We always AOT stuff here as a check before deploying. The main issue so far was the form of imports in ns forms that does not conform to what specs expects. Tests are not exactly the same but I am diverted on something else for a while.

Luc

Sent from my iPad

On Sep 15, 2016, at 11:29, Baptiste Fontaine notifications@github.com wrote:

FWIW I’m able to use Clara under 1.9-alpha12 without any apparent issue.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.