Add ability to pass attributes to consumer mount method for setting on iframe

oracle-samples / xfc

A javascript library for Cross Frame Communication

Apache License 2.0

17 stars 24 forks source link

Add ability to pass attributes to consumer mount method for setting on iframe #10

Closed neel-gandhi closed 6 years ago

neel-gandhi commented 6 years ago

Please fill out the below template as best you can.

Description of Issue

Starting from version 64, Chrome is deprecating permissions in cross origin iframes. Hence, iframe needs to have allow attribute where permissions can be set. Reference.

So, mount method in consumer has to allow passing attributes and ultimately set it on the iframe created here.

Expected Outcomes

mount() allows the attributes to be passed and sets it on the iframe.

mhemesath commented 6 years ago

I think this sounds like a reasonable enhancement.

mhemesath commented 6 years ago

@mjhenkes let me know if you have any concerns within this enhancement.

kafkahw commented 6 years ago

This issue should be resolved with this PR #11