Update dependencies and cleanup repo

oracle-samples / xfc

A javascript library for Cross Frame Communication

Apache License 2.0

17 stars 24 forks source link

Update dependencies and cleanup repo #30

Closed cody-dot-js closed 4 years ago

cody-dot-js commented 5 years ago

Summary

Fixes #29

Update dependencies
- Update babelrc
- Update eslint config and ignore
- Use .nvmrc lts/carbon (lts node v8.x)
Use yarn
Cleanup README
Fix broken tests from dependency bumps
Lint/cleanup code

Additional Info

Comparison of output: Webpack v2 vs Webpack v4 + Terser

cc: @cerner/xfc @nickpith @mjhenkes @ikottman

mjhenkes commented 5 years ago

Is this PR still active? I'd like to see xfc upgraded to babel 7, namely the babel-runtime dependency. Which will probably require a major version bump.

alex-bezek commented 5 years ago

Is this PR still active? I'd like to see xfc upgraded to babel 7, namely the babel-runtime dependency. Which will probably require a major version bump.

It seems this is very old. It also has lots of changes all grouped together. IMO if you want, update just the babel stuff without all the lint fixes and do a couple of small changes. I'll leave it up to @dev-cprice to say if he is done with this or not, but I would err on making a new PR with just the babel updates and he can always merge those changes into his branch

cody-dot-js commented 4 years ago

Closing this since it's wayyyy old and I don't know if I'll ever have time to get around to it anytime soon.