search

oracle-samples / xfc

A javascript library for Cross Frame Communication
Apache License 2.0
17 stars 24 forks source link

Add additional check for element.hasAttribute for legacy browsers #42

Closed Chris-Boyle closed 5 years ago

Chris-Boyle commented 5 years ago

Summary

We need to add an additional check on the hasAttribute property in IE10. This will check to make sure hasAttribute exists before we use it.

Additional Details

This makes the code compatible with legacy browsers and is passive to newer browsers.

Please add your name to the CONTRIBUTORS.md file. Adding your name to the CONTRIBUTORS.md file signifies agreement to all rights and reservations provided by the License.

Thanks for contributing to xfc.

NSLockhart commented 5 years ago

Probably need to add some unit tests around this.

Chris-Boyle commented 5 years ago

Closing in favor of https://github.com/cerner/xfc/pull/44