search

oracle-terraform-modules / terraform-oci-compute-instance

Terraform Module for creating Oracle Cloud Infrastructure compute instances
https://registry.terraform.io/modules/oracle-terraform-modules/compute-instance/oci/latest
Other
46 stars 62 forks source link

fix: wrong comparison is used for the display name #84

Closed alekc closed 2 years ago

alekc commented 2 years ago

In the display name in order to decide if to use a numbered suffix or not, following comparison is used: var.instance_count != "1"

The comparison will always be true, since the instance_count is an int, so the naming is not working properly as consequence.

kral2 commented 2 years ago

Hi Alexander,

Thank you for your contribution. I am reviewing it.

Before being able to merge the contribution, I will need to check if you have a signed Contribution Agreement (either personal or company level). Please see https://oca.opensource.oracle.com/

alekc commented 2 years ago

just signed it.

On Thu, 16 Dec 2021 at 08:47, Çetin ARDAL @.***> wrote:

Hi Alexander,

Thank you for your contribution. I am reviewing it.

Before being able to merge the contribution, I will need to check if you have a signed Contribution Agreement (either personal or company level). Please see https://oca.opensource.oracle.com/

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/oracle-terraform-modules/terraform-oci-compute-instance/pull/84#issuecomment-995561178, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACJ5V262O4DZK5FYHQB33TURGRQVANCNFSM5J2ZJTXA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

alekc commented 2 years ago

@kral2 any chance for merging it? :)