oracle / accelerated-data-science

ADS is the Oracle Data Science Cloud Service's python SDK supporting, model ops (train/eval/deploy), along with running workloads on Jobs and Pipeline resources.
https://accelerated-data-science.readthedocs.io/
Universal Permissive License v1.0
87 stars 43 forks source link

Added "continue-on-error: true" to step which posts coverage comment #883

Closed liudmylaru closed 3 months ago

liudmylaru commented 3 months ago

Description

With recent PR from user, who is not in special write-permission-group, there was an error in one step of our test pipeline observed. That step showed 403 erorr (https://github.com/oracle/accelerated-data-science/actions/runs/9504255692/job/26199643545?pr=869) on sending POST to add comment into respective PR. Even though GH action has permissions set to write for pull-request, user should be able to have permission to write to repo (be in that special group).

To overcome this and future issues with PR from such users I am suggesting to make a step, which adds comment to PR optional (add continue-on-error: true). We still will have our coverage reports generated and published to artifacts and PR reviewers can see coverage downloading from artifacts generated by GH actions, but this will omit such message in PR: image