[ODSC-59433] Bug fix for incorrect overrides from deployment config files

VipulMascarenhas commented 3 months ago

Description

This PR covers the following:

Issue 1:
- config overrides with restricted parameters are picked up and shown to the user in the front end. This in turn is passed along the deployment, which fails the deployment process as these are restricted.
- Fix: The api get_deployment_default_params in deployment.py will filter restricted params and would not send them in the response.
Issue 2:
- Any overrides in the config file fails the deployment as the correct configuration is not picked up when TGI container is used.
- Fix: The method create in deployment.py has been updated to take in both type of params (tgi or vllm) based on the container family used for the underlying model.

The changes for the bug fixes are in deployment.py and test_deployment.py, rest all changes are due to ruff updates.

Ruff changes: A lot of changes had to be made in this PR enforced by ruff. Some of them are:
- Removing * imports
- using {} literal instead of dict()
- except by itself should not be used
- if raising custom exception within except then raise using from ex
- use key in dict instead of key in dict.keys()
- functions that do not use parameters are removed

Jira

ODSC-59433

Unit Tests

 python -m pytest -q tests/unitary/with_extras/aqua/test_*
================================================= test session starts ==================================================
platform darwin -- Python 3.8.19, pytest-7.4.4, pluggy-1.0.0
rootdir: /Users/user/workspace/git/accelerated-data-science
configfile: pytest.ini
plugins: Faker-26.0.0, cov-5.0.0, anyio-4.2.0, xdist-3.6.1
collected 191 items

tests/unitary/with_extras/aqua/test_cli.py ..............                                                        [  7%]
tests/unitary/with_extras/aqua/test_common_handler.py ...                                                        [  8%]
tests/unitary/with_extras/aqua/test_decorator.py ..........                                                      [ 14%]
tests/unitary/with_extras/aqua/test_deployment.py ....................                                           [ 24%]
tests/unitary/with_extras/aqua/test_deployment_handler.py ..s......                                              [ 29%]
tests/unitary/with_extras/aqua/test_evaluation.py .............................                                  [ 44%]
tests/unitary/with_extras/aqua/test_evaluation_handler.py .........                                              [ 49%]
tests/unitary/with_extras/aqua/test_finetuning.py .......                                                        [ 52%]
tests/unitary/with_extras/aqua/test_finetuning_handler.py .....                                                  [ 55%]
tests/unitary/with_extras/aqua/test_global.py ...                                                                [ 57%]
tests/unitary/with_extras/aqua/test_handlers.py .................                                                [ 65%]
tests/unitary/with_extras/aqua/test_model.py .................                                                   [ 74%]
tests/unitary/with_extras/aqua/test_model_handler.py .......                                                     [ 78%]
tests/unitary/with_extras/aqua/test_ui.py ...............                                                        [ 86%]
tests/unitary/with_extras/aqua/test_ui_handler.py ..............                                                 [ 93%]
tests/unitary/with_extras/aqua/test_ui_websocket_handler.py ....                                                 [ 95%]
tests/unitary/with_extras/aqua/test_utils.py ........                                                            [100%]

=========================================== 190 passed, 1 skipped in 30.44s ============================================