oracle / accelerated-data-science

ADS is the Oracle Data Science Cloud Service's python SDK supporting, model ops (train/eval/deploy), along with running workloads on Jobs and Pipeline resources.
https://accelerated-data-science.readthedocs.io/
Universal Permissive License v1.0
87 stars 43 forks source link

Updated Job BYOC API #899

Closed lu-ohai closed 2 months ago

lu-ohai commented 3 months ago

Updated Job BYOC API

Notebook

Screenshot 2024-07-03 at 2 20 36 PM Screenshot 2024-07-03 at 2 22 06 PM Screenshot 2024-07-03 at 2 23 39 PM Screenshot 2024-07-03 at 2 24 43 PM Screenshot 2024-07-03 at 2 25 29 PM
github-actions[bot] commented 3 months ago

📌 Cov diff with main:

Coverage-70%

📌 Overall coverage:

Coverage-60.45%

mrDzurb commented 3 months ago

Do you know if it back compatible? Will the existing YAML work with the new spec?

lu-ohai commented 3 months ago

Do you know if it back compatible? Will the existing YAML work with the new spec?

Yes. There is no change for current user's experience except I added several apis to configure more properties. The logic changed is that we no longer send ENV to backend under the hood but used OcirContainerJobEnvironmentConfigurationDetails as payload instead.

github-actions[bot] commented 3 months ago

📌 Cov diff with main:

Coverage-71%

📌 Overall coverage:

Coverage-60.45%

github-actions[bot] commented 3 months ago

📌 Cov diff with main:

Coverage-24%

📌 Overall coverage:

Coverage-20.71%

github-actions[bot] commented 3 months ago

📌 Cov diff with main:

Coverage-24%

📌 Overall coverage:

Coverage-20.71%

github-actions[bot] commented 2 months ago

📌 Cov diff with main:

Coverage-24%

📌 Overall coverage:

Coverage-20.70%