search

oracle / bpftune

bpftune uses BPF to auto-tune Linux systems
Other
654 stars 55 forks source link

Ignore *.plist and *.skel.legacy.h files #48

Closed Rtoax closed 11 months ago

oracle-contributor-agreement[bot] commented 11 months ago

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA). The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

alan-maguire commented 11 months ago

change looks good, thanks! Currently the check for the Oracle Contributor Agreement is failing - instructions for OCA application are above and in https://github.com/oracle/bpftune/blob/main/CONTRIBUTING.md . If you complete that process, can you add a note here so I can see if the checks get updated correctly? Thanks!

Rtoax commented 11 months ago

change looks good, thanks! Currently the check for the Oracle Contributor Agreement is failing - instructions for OCA application are above and in https://github.com/oracle/bpftune/blob/main/CONTRIBUTING.md . If you complete that process, can you add a note here so I can see if the checks get updated correctly? Thanks!

I don't know why, i already signed the OCA, however, stuck on Oracle Contributor Agreement still. please help.

Rtoax commented 11 months ago

change looks good, thanks! Currently the check for the Oracle Contributor Agreement is failing - instructions for OCA application are above and in https://github.com/oracle/bpftune/blob/main/CONTRIBUTING.md . If you complete that process, can you add a note here so I can see if the checks get updated correctly? Thanks!

Shows 

Warning:
You cannot submit a new request unless the one that is under review is approved or rejected.
alan-maguire commented 11 months ago

i've rerun checks and they still fail; possible the approval is still pending. i don't yet see you on the list at https://oca.opensource.oracle.com/?ojr=contrib-list so it's possible it just takes a few days to show up. i'll follow up with opensource admins on monday if still not working then..

alan-maguire commented 11 months ago

Asked the admin folks; they said the OCA request was rejected because the full mailing address was not specified. Could you submit a new OCA request, making sure to match the email used in the OCA request and the pull request? thanks!

Rtoax commented 11 months ago

Asked the admin folks; they said the OCA request was rejected because the full mailing address was not specified. Could you submit a new OCA request, making sure to match the email used in the OCA request and the pull request? thanks!

I just signed OCA again, please review. thanks.

oracle-contributor-agreement[bot] commented 11 months ago

Thank you for signing the OCA.

alan-maguire commented 11 months ago

all good, merged now