oracle / cloud-native-devops-workshop

Oracle's Cloud Native and DevOps Workshop on Oracle Cloud
http://developers.oracle.com
Universal Permissive License v1.0
112 stars 225 forks source link

Fixed some mistakes in the rolling router sticky sessions with Wercker #41

Closed m0un10 closed 7 years ago

m0un10 commented 7 years ago

Hi @mikarinneoracle, Great post! I just fixed some minor mistakes in that. For instance, I couldn't build rolling-router-sticky-sessions until I build runit and confd. In addition to the minor fixes, I observed that the Wercker step mikarinneoracle/oracle-occs-rolling-router-deploy/1.1.0 currently doesn't work. It throws an error about not being able to find the tarball. Not sure if this is a bug on Wercker side or it's related to the step not being published or something else. Hope this helps! Craig

mikarinneoracle commented 7 years ago

Thanks. There was another issue with Hello world app. Let's fix that first. I will then look at this more closely. Basically this looks good. Thanks again.

mikarinneoracle commented 7 years ago

Changes copied to https://github.com/oracle/cloud-native-devops-workshop/pull/43

mikarinneoracle commented 7 years ago

@craigbarrau @mikeraab I made a change to use the occs deploy script embedded as a task step instead of using the wercker global task. It seems to work now and should not throw the error for a missing tarball. Not exactly sure what that happened (something to do with credentials).

I will document this to the lab and make a pull request for the change.

mikarinneoracle commented 7 years ago

Done.