oracle / cluster-api-provider-oci

Kubernetes Cluster API Provider for Oracle Cloud Infrastructure
https://oracle.github.io/cluster-api-provider-oci/
Apache License 2.0
40 stars 22 forks source link

feat: added pagination support for ListNetworkLoadBalancers,ListInstances #249

Closed PreethamBojja closed 1 year ago

PreethamBojja commented 1 year ago

What this PR does / why we need it: Pagination for ListNetworkLoadBalancers and ListInstances

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Ref https://github.com/oracle/cluster-api-provider-oci/issues/97

oracle-contributor-agreement[bot] commented 1 year ago

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA). The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

PreethamBojja commented 1 year ago

unit tests

?       github.com/oracle/cluster-api-provider-oci  [no test files]
ok      github.com/oracle/cluster-api-provider-oci/api/v1beta1  49.494s coverage: 23.9% of statements
ok      github.com/oracle/cluster-api-provider-oci/api/v1beta2  1.396s  coverage: 16.3% of statements
?       github.com/oracle/cluster-api-provider-oci/cloud/config [no test files]
ok      github.com/oracle/cluster-api-provider-oci/cloud/ociutil    0.632s  coverage: 19.6% of statements
ok      github.com/oracle/cluster-api-provider-oci/cloud/scope  233.684s    coverage: 77.3% of statements
?       github.com/oracle/cluster-api-provider-oci/cloud/scope/mocks    [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/base  [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/base/mock_base    [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/compute   [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/compute/mock_compute  [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/computemanagement [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/computemanagement/mock_computemanagement  [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/containerengine   [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/containerengine/mock_containerengine  [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/identity  [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/identity/mock_identity    [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/loadbalancer  [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/loadbalancer/mock_lb  [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/networkloadbalancer   [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/networkloadbalancer/mock_nlb  [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/vcn   [no test files]
?       github.com/oracle/cluster-api-provider-oci/cloud/services/vcn/mock_vcn  [no test files]
ok      github.com/oracle/cluster-api-provider-oci/cloud/util   1.309s  coverage: 58.5% of statements
ok      github.com/oracle/cluster-api-provider-oci/controllers  29.356s coverage: 67.5% of statements
ok      github.com/oracle/cluster-api-provider-oci/exp/api/v1beta1  34.482s coverage: 21.8% of statements
ok      github.com/oracle/cluster-api-provider-oci/exp/api/v1beta2  1.239s  coverage: 11.0% of statements
ok      github.com/oracle/cluster-api-provider-oci/exp/controllers  1.599s  coverage: 56.3% of statements
?       github.com/oracle/cluster-api-provider-oci/feature  [no test files]
?       github.com/oracle/cluster-api-provider-oci/version  [no test files]
joekr commented 1 year ago

Sorry, just getting around to running the e2e tests.

e2e tests

Ran 6 of 25 Specs in 3682.852 seconds
SUCCESS! -- 6 Passed | 0 Failed | 0 Pending | 19 Skipped