oracle / cluster-api-provider-oci

Kubernetes Cluster API Provider for Oracle Cloud Infrastructure

https://oracle.github.io/cluster-api-provider-oci/

Apache License 2.0

38 stars 21 forks source link

Confirm pagination on all list call #97

Open joekr opened 2 years ago

joekr commented 2 years ago

What would you like to be added: We need this to run through all pages and return the full list of running instances https://github.com/oracle/cluster-api-provider-oci/blob/main/cloud/scope/machine_pool.go#L158

Also should check all other list calls are using pagination.

Why is this needed: As clusters grow we want to make sure we don't miss running instances.

joekr commented 2 years ago

checks indicate complete

compute

[x] ListInstances
[x] ListVnicAttachments

compute management

[x] ListInstancePools
[x] ListInstancePoolInstances
[x] ListInstanceConfigurations - currently not used

identity

[x] ListRegions
[x] ListFaultDomains
[x] ListAvailabilityDomains

Identity calls do not support pagination

network load balancer

[x] ListNetworkLoadBalancers

vcn

[x] ListVcns
[x] ListSubnets
[x] ListRouteTables
[x] ListSecurityLists
[x] ListInternetGateways
[x] ListNatGateways
[x] ListServiceGateways
[x] ListServices
[x] ListNetworkSecurityGroups
[ ] ListNetworkSecurityGroupSecurityRules
[x] ListDrgs
[x] ListDrgAttachments
[x] ListRemotePeeringConnections