search

oracle / cordova-plugin-wkwebview-file-xhr

Cordova Plugin for WebView File XHR
Universal Permissive License v1.0
138 stars 120 forks source link

Fix formData Polyfill for radios&co #28

Closed GexxOn closed 4 years ago

GexxOn commented 5 years ago

This is a fix for the FormData Polyfill. It does not handle radio, checkboxes and other special input types correctly. Feel free to copy the changes if this PR can not directly merged (sorry for the commit messages ;)).

all the best gexx

gvanmat commented 5 years ago

@GexxOn Thanks for bring this issue to attention. Looks like the core issue is there is a typo in the logic that inspects a full form element passed to the FormData constructor. The radio and select check should be on element.type instead of element.value. I won't be able to address this issue any time soon. Please file a issue, if you have the time.

manish2788 commented 4 years ago

Since we don't accept pull requests. We will be tracking this issue with our internal issue tracker and will further release the plugin with fix.