Fix double encoding of URL

oracle / cordova-plugin-wkwebview-file-xhr

Cordova Plugin for WebView File XHR

Universal Permissive License v1.0

138 stars 120 forks source link

Fix double encoding of URL #48

Closed kp42 closed 4 years ago

kp42 commented 4 years ago

This commit will check if the provided URL is already encoded. This is needed because the stringByAddingPercentEncodingWithAllowedCharacters does not check for that and causes the URL to be double encoded.

See here for more information https://developer.apple.com/documentation/foundation/nsstring/1411946-stringbyaddingpercentencodingwit?language=objc

Fixes #41

manish2788 commented 4 years ago

@kp42 Thanks for sharing your solution to the reported issue. Meanwhile we have pushed the changes to master branch which will be resolving the mentioned issue.

kp42 commented 4 years ago

@manish2788 Thank you, I can confirm that the pushed changes fix our issue. Will close this PR.