oracle / docker-images

Official source of container configurations, images, and examples for Oracle products and projects
https://developer.oracle.com/use-cases/#containers
Universal Permissive License v1.0
6.59k stars 5.44k forks source link

Incorrect syntax for installing ORDS in Dockerfile #2566

Open styledigger opened 1 year ago

styledigger commented 1 year ago

Dockerfile for building ords image (https://github.com/oracle/docker-images/blob/main/OracleRestDataServices/dockerfiles/Dockerfile) contains following command on line# 65: java -jar $ORDS_HOME/ords.war configdir $ORDS_HOME/config && \

When building image with ords-22.4.3.033.1239.zip in current folder using

./buildContainerImage.sh -i -o '--build-arg BASE_IMAGE=localhost/oracle/jdk:17-ol8'

line 65 in Dockerfile produces following messages on standard output (It looks like ords 22.4.3 does not support the "configdir" command.):

Warning: Support for executing: java -jar ords.war has been deprecated.
Please add ords to your PATH and use the ords command instead.
Run the following command to add ords to your PATH:

echo -e 'export PATH="$PATH:/opt/oracle/ords/bin"' >> ~/.bash_profile

Start a new shell to pick up this change.
2023-02-20T07:17:46.832Z INFO        Your configuration folder /opt/oracle/ords is located in ORDS product folder.  Oracle recommends to use a different configuration folder.

ORDS: Release 22.4 Production on Mon Feb 20 07:17:46 2023

Copyright (c) 2010, 2023, Oracle.

Configuration:
  /opt/oracle/ords/

Usage:
  ords [OPTIONS] [COMMAND]

Oracle REST Data Services command line interface

Options:
        --config <folder>        Path to Oracle REST Data Services
                                 configuration folder

        --debug                  Equivalent to --verbose

    -h, --help                   Show usage information for the command

    -v, --verbose                Configure Oracle REST Data Services to run in
                                 verbose mode

        --version                Show version information

Commands:
        config                   Configure application and database connection
                                 pool settings

        extract                  Extracts Oracle REST Data Services scripts.

        install                  Configure database connection and
                                 install/upgrade Oracle REST Data Services
                                 schema, ORDS database user and related
                                 database objects.

        migrate                  Migrates Oracle REST Data Services
                                 configuration files and parameter file from
                                 release 21.4.x and earlier releases.

        serve                    Launch Oracle REST Data Services in standalone
                                 mode

        uninstall                Uninstall Oracle REST Data Services schema,
                                 ORDS database user and related database
                                 objects.

        war                      Create a web application from the the
                                 distributed ords.war that can be deployed in a
                                 supported servlet container. 

Run ords <COMMAND> --help for more information on a command.

For example run: ords config --help
pobalopalous commented 1 year ago

While waiting on the Dockerfile & scripts to be updated for ORDS 22.1.0+, can the README.md be updated ( perhaps in the Known Issues section ) that the scripts in the repo are only valid for ORDS 21.4.3 and earlier?