search

oracle / docker-images

Official source of container configurations, images, and examples for Oracle products and projects
https://developer.oracle.com/use-cases/#containers
Universal Permissive License v1.0
6.51k stars 5.41k forks source link

Update hostname in runOracle.sh and configTcps.sh #2665

Closed viragtripathi closed 1 year ago

viragtripathi commented 1 year ago

Resolution for hostname command not found.

oracle-contributor-agreement[bot] commented 1 year ago

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA). The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

yunus-qureshi commented 1 year ago

@viragtripathi please clarify if this for the ARM64 image?

viragtripathi commented 1 year ago

@viragtripathi please clarify if this for the ARM64 image?

@yunus-qureshi yes this is for the ARM64 image and I think we should also check for arch type then apply the hostname fix for arm64.

yunus-qureshi commented 1 year ago

@viragtripathi please clarify if this for the ARM64 image?

@yunus-qureshi yes this is for the ARM64 image and I think we should also check for arch type then apply the hostname fix for arm64.

Thanks @viragtripathi we are going to fix this differently. @aditya059 will raise a PR. Thanks

viragtripathi commented 1 year ago

@viragtripathi please clarify if this for the ARM64 image?

@yunus-qureshi yes this is for the ARM64 image and I think we should also check for arch type then apply the hostname fix for arm64.

Thanks @viragtripathi we are going to fix this differently. @aditya059 will raise a PR. Thanks

Sounds good @yunus-qureshi. Thanks for the quick response.

aditya059 commented 1 year ago

This issue will be fixed as part of PR #2666