oracle / docker-images

Official source of container configurations, images, and examples for Oracle products and projects
https://developer.oracle.com/use-cases/#containers
Universal Permissive License v1.0
6.47k stars 5.41k forks source link

oracle-db Helm chart re-generates the password secret at each deploy #2676

Open RobbieFernandez opened 12 months ago

RobbieFernandez commented 12 months ago

The oracle-db helm chart located here: OracleDatabase/SingleInstance/helm-charts/oracle-db has a secrets manifest that renders a random string as the database password. This value is re-generated every single time the chart is rendered. The actual database password however does not seem to be update to match the new secret, meaning any pods that reference this secret will now have the incorrect password.

I believe the solution is to wrap this line in a lookup check, to first see if the secret already exists, and only generate the new value if it does. https://github.com/oracle/docker-images/blob/df7def137d8c7365df7a2f2ba330b3f0624b61fa/OracleDatabase/SingleInstance/helm-charts/oracle-db/templates/secrets.yaml#L13