oracle / docker-images

Official source of container configurations, images, and examples for Oracle products and projects
https://developer.oracle.com/use-cases/#containers
Universal Permissive License v1.0
6.47k stars 5.41k forks source link

min docker version check fails on docker 24.0.5 #2688

Closed robert-s-lee closed 11 months ago

robert-s-lee commented 11 months ago

upgraded to new docker version on a mac

docker --version
Docker version 24.0.5, build ced0996

build fails on docker version check

WARNING: daemon is not using the default seccomp profile
Checking Docker version.
Docker version is below the minimum required version 17.09
Please upgrade your Docker installation to proceed.

the issues comes from

https://github.com/oracle/docker-images/blob/446229a885b9180aeac12c333bece3ad663a556d/OracleDatabase/SingleInstance/dockerfiles/buildContainerImage.sh#L93C1-L94C1 which reports 24.0 and not 24.00

DOCKER_VERSION=$("${CONTAINER_RUNTIME}" version --format '{{.Server.Version }}'|| exit 0)
pple:~ rslee$ echo $DOCKER_VERSION
24.0
aditya059 commented 11 months ago

Hi @robert-s-lee

I tried the same on my mac. I am not getting this error.

mac ~ % docker --version Docker version 24.0.5, build ced0996 mac ~ % mac ~ % mac ~ % DOCKER_VERSION=$(docker version --format '{{.Server.Version }}'|| exit 0) mac ~ % echo $DOCKER_VERSION 24.0.5

aditya059 commented 11 months ago

Closing this issue as it is not reproducible at our end

robert-s-lee commented 11 months ago

@aditya059 that is weird. looks like the same docker version but returns different results on my mac.

docker --version
Docker version 24.0.5, build ced0996

docker version --format '{{.Server.Version }}'
24.0

DOCKER_VERSION=$(docker version --format '{{.Server.Version }}'|| exit 0)
pple:Downloads rslee$ echo $DOCKER_VERSION
24.0
aditya059 commented 11 months ago

@robert-s-lee Yes, its strange. I guess it is happening only on your machine because we haven't had anyone else filing this issue.