search

oracle / docker-images

Official source of container configurations, images, and examples for Oracle products and projects
https://developer.oracle.com/use-cases/#containers
Universal Permissive License v1.0
6.45k stars 5.4k forks source link

Remove +dfsg* from docker version #2757

Open ReneNyffenegger opened 5 months ago

ReneNyffenegger commented 5 months ago

On some Debian installations, the following command docker version --format '{{.Server.Version}}' returns a version number with +dfsg... added, for example: 20.10.5+dfsg1

After removing the dots, the comparison of DOCKER_VERSION with MIN_DOCKER_VERSION throws ./buildContainerImage.sh: line 97: [: 20105+dfsg1: integer expression expected

This pull request also adds the substring +dfsg* from the version number in order for the comparison to have numerical values on both sides.

oracle-contributor-agreement[bot] commented 5 months ago

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA). The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

oracle-contributor-agreement[bot] commented 5 months ago

Thank you for signing the OCA.