search

oracle / docker-images

Official source of container configurations, images, and examples for Oracle products and projects
https://developer.oracle.com/use-cases/#containers
Universal Permissive License v1.0
6.45k stars 5.4k forks source link

Oracle GoldenGate #2780

Closed sbalousek closed 2 months ago

sbalousek commented 2 months ago
sbalousek commented 2 months ago

Thanks for your time, @Djelibeybi !

Djelibeybi commented 2 months ago

Thanks for your time, @Djelibeybi !

You're welcome. :)

sbalousek commented 2 months ago

@Djelibeybi - One last thing: we cannot merge until OGG 23 is released. I will let you know.

sbalousek commented 2 months ago

Hi @Djelibeybi - I am having trouble finding the error in the super linter check. Any pointers would be appreciated.

Djelibeybi commented 2 months ago

Hi @Djelibeybi - I am having trouble finding the error in the super linter check. Any pointers would be appreciated.

The linting issues are being found by SHELL_SHFMT and can be seen by expanding that section or by clicking here: https://github.com/oracle/docker-images/actions/runs/8926398614/job/24517335048?pr=2780#step:5:233

Djelibeybi commented 2 months ago

Though, now that I'm looking at it closely, I'm not sure I agree with the linter on a few things (like its suggested indentation or lack thereof). I'll take a closer look tomorrow or over the weekend and tweak the linter as necessary. If you feel the linter is being overly pedantic, let me know and I'll merge after I do a final manual check.

sbalousek commented 2 months ago

I simply do not see the error. The shfmt tool is too aggressive with regard to whitespace, marking style differences as errors. I made the suggested corrections, which are still failing for no apparent reason. When I run shfmt locally, the return code is 0 for all files using shfmt -w -i 4.

As far as I can tell, this PR failed because shfmt expects TAB indentation, which I don't agree with. Other than that, I see no errors.

shfmt did, however, find an issue that ShellCheck did not.

sbalousek commented 2 months ago

These changes - which are critical to the GoldenGate 23ai release - passed lint checks a few weeks ago. If there is anything you can do before next week, I would really appreciate it.

sbalousek commented 2 months ago

I thought about this more and realized TAB characters are the current requirement (per shfmt), so I reformatted and tested the scripts.

sbalousek commented 2 months ago

Thanks a bunch, Avi. Have a fantastic weekend!

Djelibeybi commented 2 months ago

Thanks a bunch, Avi. Have a fantastic weekend!

You're welcome and likewise.