search

oracle / dtrace-utils

DTrace-utils contains the DTrace port to Linux
Other
151 stars 20 forks source link

test: stop hardcoding /usr/bin/gcc #75

Open thesamesam opened 2 months ago

thesamesam commented 2 months ago

Many tests have lines like test/unittest/usdt/tst.guess32.sh:14:CC=/usr/bin/gcc. They should respect CC from the environment to allow testing with different GCC versions.

e.g. On my system, /usr/bin/gcc is usually GCC trunk, but I might want to compare GCC 14 with that to check for regressions.

thesamesam commented 2 months ago

The same is true for objdump and all such toolchain tools.

kvanhees commented 2 months ago

+1

nickalcock commented 2 months ago

Totally agreed. This was a short-term kludge of mine in 2011 -- it's long past time for it to get fixed properly. A nice boring job given how pervasive this is :)

thesamesam commented 2 months ago

I don't mind taking it. I already have a stack of other test fixes it might conflict with, even.

ezannoni commented 4 weeks ago

Do we have a patch for this?

thesamesam commented 4 weeks ago

No, I'm happy to do it, but I was hoping to have my test fixes in first (already sent). I can prepare the patches now but I was worried about conflicts.

kvanhees commented 4 weeks ago

I am looking at the patches already submitted to pull them in.

nickalcock commented 3 days ago

I'm afraid that's almost certain to clash like mad with https://github.com/oracle/dtrace-utils/commit/c80d7ebb0b1b413115d94f5004caa1f62c9c76f7 which I'm getting reviewed now :(