search

oracle / dtrace-utils

DTrace-utils contains the DTrace port to Linux
Other
152 stars 20 forks source link

dtprobed: drop libsystemd linkage #92

Closed thesamesam closed 3 weeks ago

thesamesam commented 2 months ago

Using libsystemd purely for sd_notify got a tonne of discussion after the xz backdoor.

At that time, Lennart himself posted saying that projects shouldn't bring in libsystemd purely for the simple sd_notify API:

In the past, I have been telling anyone who wanted to listen that if all you want is sd_notify() then don't bother linking to libsystemd, since the protocol is stable and should be considered the API, not our C wrapper around it.

See https://www.freedesktop.org/software/systemd/man/devel/sd_notify.html#Standalone%20Implementations for an example.

Let's NIH the trivial protocol to drop a hefty library from a privileged, albeit tiny, daemon.

nickalcock commented 2 months ago

Agreed. I've been thinking of this for some time. It's about five lines, and we're doing something similar just to daemonize dtprobed in the absence of systemd anyway.

thesamesam commented 3 weeks ago

Thanks!