oracle / dtrace-utils

DTrace-utils contains the DTrace port to Linux
Other
133 stars 19 forks source link

dtprobed: provide tmpfiles snippet #93

Closed thesamesam closed 1 month ago

thesamesam commented 1 month ago

For non-systemd installs especially (but not exclusively), we should provide a tmpfiles.d snippet to safely create /run/dtrace without race conditions with the correct privileges.

Otherwise, people are prone to doing it incorrectly/unsafely in init scripts.

nickalcock commented 1 month ago

There shouldn't be any race conditions (dtprobed is a singleton), and dtprobed has too create the tmpdir anyway if not present, so I'm not really sure what tmpfiles.d brings us. Nobody should be creating /run/dtrace by hand!

thesamesam commented 1 month ago

If we fail gracefully and don't attempt to chown if it already exists, we're OK. It looks like we handle it fine (we complain if it already exists), so let's close.