different behavior when calling expect_error with testthat

oracle / fastr

A high-performance implementation of the R programming language, built on GraalVM.

Other

623 stars 64 forks source link

different behavior when calling expect_error with testthat #32

Closed comicfans closed 5 years ago

comicfans commented 5 years ago

following code did nothing in GnuR

library(testthat) expect_error(var = 3)

but raise error in fastR:

Error in is.character(expr) : argument "x" is missing, with no default

steve-s commented 5 years ago

Hi comicfans,

what version of GraalVM/FastR are you using? ~I tried on both the RC9 and the current development version of FastR and can't reproduce this. Maybe we'll need some code that preceded this code to reproduce the error.~ Edit: my bad, I can reproduce now on RC9. Thank you for the report, it seems to be fixed in the development version, which you can try via https://github.com/nuest/fastr-docker

comicfans commented 5 years ago

Hi steve:

I've confirmed that fastr 3389c8c didn't have such problem any more. plus that docker file seems out dated (docker use openjdk but fastr requires special jdk from oracle)