[GR-59532] Unify SnippetTemplate.Arguments.add() and SnippetTemplate.Arguments.addConst()

oracle / graal

GraalVM compiles Java applications into native executables that start instantly, scale fast, and use fewer compute resources 🚀

https://www.graalvm.org

Other

20.42k stars 1.64k forks source link

[GR-59532] Unify SnippetTemplate.Arguments.add() and SnippetTemplate.Arguments.addConst() #10093

Closed graalvmbot closed 1 week ago

graalvmbot commented 1 week ago

This PR merges the functionality of SnippetTemplate.Arguments.addConst() into SnippetTemplate.Arguments.add(). I have stumbled into errors before due to mistakenly calling add() instead of addConst(). The changes in this PR should prevent that from happening in the future. addVarargs() is still left unchanged, since that one has a much different usage pattern, so it's not really possible to confuse it with add().