Open navyxliu opened 1 year ago
Hi, Thank you for your suggestion, we'll take a look into it shortly
hi, @oubidar-Abderrahim I can contribute a patch to fix this issue and I have signed OCA. please let me know if you are interested in supporting binary Info.plist on MacOS.
@navyxliu Did you get a patch together? I'm facing the same issue.
Hi, @toddjonker
I didn't make a patch. it's because it's unclear Graal would take it or it's a package issue of jdk.
That being said, this problem is easy to work around.
./sdk/mx.sdk/mx_sdk_vm_impl.py expects the plist file in XML format. we could use plutil
to convert plist file in Corretto to XML.
thanks, --lx
Feature request
Please include the following information:
Is your feature request related to a problem? Please describe. I can't use some other JDK binary distributions to bootstrap graalvm on MacOS. eg. Corretto-17 also supports CI.
here are logs I got. It's passed JVMCIVersionCheck.java but fails in
_patch_darwin_jdk
of mx.sdk.Describe the solution you'd like. A clear and concise description of what you want to happen.
The rootcause is that current
mx_sdk_vm_impl.py
can't recognize 'info.plist' in binary format from some jdk distributions. I inspect the jdks provides by oraclelabs. They are all in xml format, so it's fine with them.There's a simple solution. plutil provided by MacOS can easily convert the binary plist to textual xml1. All we need to do is to wrap
etreeParse(orig_info_plist)
with a try/catch construct.Describe who do you think will benefit the most. GraalVM users, GraalVM contributors, developers of libraries and frameworks which depend on GraalVM, or somebody else?
Graal developers would have more selection of jdks and oraclelabs could switch to the binary Info.plist freely.
Describe alternatives you've considered. A clear and concise description of any alternative solutions or features you've considered.
Instead of converting info.plist in memory, it's possible that mx.sdk script converts the binary plist to a textual file. It'll involve in a temporary file. It's more complex and less secure.
Additional context. Add any other context about the feature request here. For example, link to the relevant projects, documentation, standards.
Express whether you'd like to help contributing this feature If you'd like to contribute, please read the contribution guide.
yes.