search

oracle / graalpython

A Python 3 implementation built on GraalVM
Other
1.21k stars 104 forks source link

Fix #190: Isolate STATIC_CONFIG_OPTIONS #192

Closed kariya-mitsuru closed 3 years ago

kariya-mitsuru commented 3 years ago

I think WITH_THREAD should be kept per Context.

timfel commented 3 years ago

Sorry, as mentioned on the issue, these options are simply going away in the next release

msimacek commented 3 years ago

Hi, the threading effort that will make this option obsolete is taking more time than expected and more people are running into the problem. I'd like to accept this PR to fix the problem until threading is complete.

msimacek commented 3 years ago

@timfel I noticed you said on the issue that it still wouldn't work very well when on the context. Do you think we could still accept this as an incremental improvement over the current situation to avoid other people tripping over this?

timfel commented 3 years ago

@timfel I noticed you said on the issue that it still wouldn't work very well when on the context. Do you think we could still accept this as an incremental improvement over the current situation to avoid other people tripping over this?

yes, it's fine to accept as-is, we will refactor once the threading PR is ready