Closed kfirt closed 1 year ago
As discussed on Slack, the issue with ==
is that our str.__eq__
implementation does not support j.l.String
instances anymore, only our new internal type TruffleString
. We will fix this use case for the next release
The fix for this is now on master, and will be released with 23.0.0 in January. The reproducer you have provided was added to our test suite so we won't regress on this again. Thank you for your help in tracking this down!
Seems like there is a regression in 22.3.0 when using java Maps. Using the code below
True
for bothmymap['source'] == 'foo'
andmymap.get('source') == 'foo'
False
formymap['source'] == 'foo'
andTrue
formymap.get('source') == 'foo'
If you could also remove the assertions from
com.oracle.graal.python.nodes.truffle.TruffleStringMigrationHelpers
it will ease running JUnit tests on our end