search

oracle / graalpython

A Python 3 implementation built on GraalVM
Other
1.2k stars 104 forks source link

CVE-2007-4559 Patch #294

Closed TrellixVulnTeam closed 1 year ago

TrellixVulnTeam commented 1 year ago

Patching CVE-2007-4559

Hi, we are security researchers from the Advanced Research Center at Trellix. We have began a campaign to patch a widespread bug named CVE-2007-4559. CVE-2007-4559 is a 15 year old bug in the Python tarfile package. By using extract() or extractall() on a tarfile object without sanitizing input, a maliciously crafted .tar file could perform a directory path traversal attack. We found at least one unsantized extractall() in your codebase and are providing a patch for you via pull request. The patch essentially checks to see if all tarfile members will be extracted safely and throws an exception otherwise. We encourage you to use this patch or your own solution to secure against CVE-2007-4559. Further technical information about the vulnerability can be found in this blog.

If you have further questions you may contact us through this projects lead researcher Kasimir Schulz.

oracle-contributor-agreement[bot] commented 1 year ago

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA). The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

timfel commented 1 year ago

Hello, and thanks for the PR. This PR addresses an issue in the Python standard library, which we inherit from CPython. The issue exists in CPython's stdlib and they are discussing a fix here: https://github.com/python/cpython/issues/73974. The issue has been known for years, and Red Hat's security team rated this as low severity years ago: see https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=263261 and https://nvd.nist.gov/vuln/detail/CVE-2007-4559. Thus, I recommend you work with upstream to fix this and the fix will naturally be picked up by us since we sync the Python standard library.