search

oracle / graalpython

A Python 3 implementation built on GraalVM
Other
1.2k stars 103 forks source link

remove usage of os.O_NOCTTY in getpass module #318

Closed The-Alchemist closed 1 year ago

The-Alchemist commented 1 year ago

os.O_NOCTTY is not implemented (yet?), and it doesn't seem to make a difference in getpass() usage anyway.

O_NOCTTY docs


       O_NOCTTY
              If pathname refers to a terminal device—see tty(4)—it will
              not become the process's controlling terminal even if the
              process does not have one.

https://man7.org/linux/man-pages/man2/openat.2.html

oracle-contributor-agreement[bot] commented 1 year ago

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA). The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

The-Alchemist commented 1 year ago

Thanks, @msimacek . I'll close this PR and open a new one after running the gen scripts.