search

oracle / graalpython

A Python 3 implementation built on GraalVM
Other
1.2k stars 103 forks source link

Added patch for charset-normalizer == 3.1.0 #319

Closed The-Alchemist closed 1 year ago

The-Alchemist commented 1 year ago

utils.py has changed slightly:

https://github.com/Ousret/charset_normalizer/blob/3.1.0/charset_normalizer/utils.py

Collecting charset-normalizer<4.0,>=2.0
  Downloading charset_normalizer-3.1.0-py3-none-any.whl (46 kB)
     |████████████████████████████████| 46 kB 631 kB/s
Looking for GraalPy patches for charset_normalizer
Patching package charset_normalizer using /Library/Java/JavaVirtualMachines/graalvm-ce-java19-22.3.1/Contents/Home/languages/python/lib-graalpython/patches/charset_normalizer/whl/charset_normalizer.patch
patching file charset_normalizer/utils.py
Hunk #1 FAILED at 11.
Hunk #2 succeeded at 258 with fuzz 2 (offset 11 lines).
1 out of 2 hunks FAILED -- saving rejects to file charset_normalizer/utils.py.rej
msimacek commented 1 year ago

Thank you for the contribution, I'll try to get it merged shortly.

The-Alchemist commented 1 year ago

Thanks, no rush @msimacek . charset-normalizer works anyway because the hunk #1 of patch fails because the change is just the removal of a comment.

The-Alchemist commented 1 year ago

@msimacek : are Python package patches like this one available instantly, or are they packaged in GraalPython (and we need to wait for the next GraalVM release)?

Thank you!

msimacek commented 1 year ago

They are packged in GraalVM and will be available in the next release. But you can download a snapshot build here: https://github.com/graalvm/graalvm-ce-dev-builds/releases/, it should normally contain graalpy from the week before.