search

oracle / graalpython

A Python 3 implementation built on GraalVM
Other
1.17k stars 101 forks source link

Add rudimentary support for _tkinter in GraalPy #381

Open phkeese opened 5 months ago

phkeese commented 5 months ago

This commit adds the _tkinter module to the list of built-in modules to allow use of tkinter. Before use, the bindings need to be built using tklib_build.py. The code was modified from existing code in PyPy's main branch.

Right now, opening a window under Linux works, but still crashes on interacting with UI elements such as buttons. It seems like there is a bug in the cffi module causing a SegFault. macOS complains about other threads accessing the main window and the build script has some trouble finding the correct library for Tcl and Tk, as macOS comes with an older version preinstalled. Windows was not tested.

Tests Running CPython's tests for tkinter and ttk shows some success, but some tests still fail, raise an error or even crash with a segmentation fault: image image

The main culprit for the failing tests seem to be Unicode errors, PyPy's 3.8 branch seems to fix those.

oracle-contributor-agreement[bot] commented 5 months ago

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA). The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.