search

oracle / javavscode

Java platform support for Visual Studio Code for full featured Java development (edit-compile-debug & test cycle)
Apache License 2.0
231 stars 31 forks source link

[JVSC-253] Refactor Netbeans localisation build #282

Closed sid-srini closed 2 months ago

sid-srini commented 2 months ago

  1. Moved the addition of the build project dirs locale_ja and locale_zh_CN to nbcode/l10n/ from inside netbeans-l10n/.

    • This is because the netbeans-l10n repo provides the build projects locale_de/ and locale_cs/ only as samples.
    • Thus the repo would not need to accept more such samples causing bloat.
    • Only the addition of localised messages for the java.lsp.server module is included in the patch.
    • This slimmed and renamed patch maybe submitted to the repo as a PR.

  2. Enhanced the Package ant task definition in netbeans-l10n to:

    • Support accepting disabledModules and enabledClusterPath as input.
    • These are used to filter unneeded clusters and modules from being built.
    • The platform properties disabled.modules and cluster.path can be used to set these parameters.
    • The former is expected to contain comma-separated module names.
    • The latter is expected to contain path-delimiter separated cluster paths.
    • This is stored in patches/l10n/filter-enabled-clusters-disabled-modules-code-cleanup.diff
    • This may also be submitted to the repo as a PR.

  3. Fixed nbcode/nbproject/platform.properties to specify ${path.separator} instead of ':' for the cluster.path value separator.

    • This is needed for build support on windows.

  4. Loaded the platform.properties in the locale build scripts and pass the values for disabled.modules and cluster.path to the buildPackage task.

  5. Updated the build.xml scripts to pass the appropriate property values for the netbeans/ and netbeans-l10n/ dirs.

  6. Fixed the clean-l10n target to clean out the copied artifacts from vscode/nbcode/extras/

  7. Fixed minor typos.

  8. Changed javac source 1.8 -> release 17