issues
search
oracle
/
javavscode
Java platform support for Visual Studio Code for full featured Java development (edit-compile-debug & test cycle)
Apache License 2.0
231
stars
31
forks
source link
[JVSC-300] Remove quoting in nbcode launch arguments
#301
Closed
sid-srini
closed
1 month ago
sid-srini
commented
1 month ago
The nbcode executable is launched from the ts/js extension using Node's
child_process.spawn
function.
This function directly launches the command in a new process. It does NOT create a shell to execute it; unlike
child_process.exec
.
Therefore, quoting the arguments passed to prevent shell splitting is not required.
In fact, due to the presence of extra quotes, it may lead to incorrect splitting of arguments with spaces in them.
This is the cause for the initialization failure of the extension nbls when the project folder opened contains spaces in its path.
Fixed
nbcode.ts
to remove the extra quotes added for some of the option values.
Closes #300
child_process.spawn
function.child_process.exec
.Closes #300