oracle / nb-javac

nb-javac is the Java compiler plugin used by the Apache NetBeans Java Editor
GNU General Public License v2.0
20 stars 21 forks source link

No need to edit anything in the repository to publish to Maven #6

Closed JaroslavTulach closed 3 years ago

JaroslavTulach commented 3 years ago

Thanks a lot for accepting #2 prepared by @matthiasblaesing which also includes my "pluggable groupId" idea. Now it is time for 3rd parties (like @eppleton) to try to upload the snapshot bits using:

$ ant -f ./make/langtools/netbeans/nb-javac publish-to-ossrh-snapshots -Dmaven.groupId=their.grp.id

I did some testing previously and it seemed to work, but I don't have OSSRH account so, my test always ended with 403 - access denied. Now when the change is in, real testing is needed...

Also, when re-reading the how-to I realized it still contains original step 3 that my "pluggable group ID" eliminated. This PR fixes that by removing the step. It shall be enough to execute

$ ant -f ./make/langtools/netbeans/nb-javac publish-to-ossrh-snapshots -Dmaven.groupId=their.grp.id

to handle the upload.

eppleton commented 3 years ago

I just uploaded it to snapshots using the DukeScript account and namespace:

https://oss.sonatype.org/content/repositories/snapshots/com/dukescript/nbjavacn/nb-javac/15-SNAPSHOT/nb-javac-15-20210115.075156-1-sources.jar

https://oss.sonatype.org/content/repositories/snapshots/com/dukescript/nbjavacn/nb-javac/15-SNAPSHOT/maven-metadata.xml

https://oss.sonatype.org/content/repositories/snapshots/com/dukescript/nbjavacn/nb-javac/15-SNAPSHOT/nb-javac-15-20210115.075156-1-javadoc.jar

https://oss.sonatype.org/content/repositories/snapshots/com/dukescript/nbjavacn/nb-javac/15-SNAPSHOT/maven-metadata.xml

So I can confirm everything is working fine and I’m ready to further help with this issue.

Cheers

Toni

Von: Jaroslav Tulach notifications@github.com Antworten an: oracle/nb-javac reply@reply.github.com Datum: KW 2,Freitag, 15. Januar 2021 um 07:21 An: oracle/nb-javac nb-javac@noreply.github.com Cc: Anton Epple toni.epple@eppleton.de, Mention mention@noreply.github.com Betreff: [oracle/nb-javac] No need to edit anything in the repository to publish to Maven (#6)

Thanks a lot for accepting #2 prepared by @matthiasblaesing which also includes my "pluggable groupId" idea. Now it is time for 3rd parties (like @eppleton) to try to upload the snapshot bits using:

$ ant -f ./make/langtools/netbeans/nb-javac publish-to-ossrh-snapshots -Dmaven.groupId=their.grp.id I did some testing previously and it seemed to work, but I don't have OSSRH account so, my test always ended with 403 - access denied. Now when the change is in, real testing is needed...

Also, when re-reading the how-to I realized it still contains original step 3 that my "pluggable group ID" eliminated. This PR fixes that by removing the step. It shall be enough to execute

$ ant -f ./make/langtools/netbeans/nb-javac publish-to-ossrh-snapshots -Dmaven.groupId=their.grp.id to handle the upload.

You can view, comment on, or merge this pull request online at: https://github.com/oracle/nb-javac/pull/6 Commit Summary No need to edit anything in the repository to publish to Maven File Changes M README.md (9) Patch Links: https://github.com/oracle/nb-javac/pull/6.patch https://github.com/oracle/nb-javac/pull/6.diff — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

matthiasblaesing commented 3 years ago

@JaroslavTulach the change looks sane to me - indeed after our discussion that paragraph is not needed. @eppleton staging the build should also work (target publish-to-maven-central). The target does not directly publish the build, but only creates the staging repository that then can be released. You can go even one step further without actually releasing - you can close the repository, which will trigger the pre-checks. After that is finished, you can still drop the repository without releasing it. The crucial point is, that "release" is the critical operation, that should only be invoked if a release is really intended.

JaroslavTulach commented 3 years ago

https://oss.sonatype.org/content/repositories/snapshots/com/dukescript/nbjavacn/nb-javac/

Hello Toni, don't you have a typo in your groupId?

arvindaprameya commented 3 years ago

Modification to readme file is fine, Approved. Thanks for doing this Yarda