Setting connection.module to undefined fails

oracle / node-oracledb

Oracle Database driver for Node.js maintained by Oracle Corp.

http://oracle.github.io/node-oracledb/

Other

2.25k stars 1.07k forks source link

Setting connection.module to undefined fails #1507

Closed ReneBeszon closed 2 years ago

ReneBeszon commented 2 years ago

Dear all,

reading the documentation from connection.module setting it to undefined is allowed

but when doing so, it results in a database error

NJS-004: invalid value for property module

when setting to "" everything works fine.

cjbj commented 2 years ago

Our doc https://oracle.github.io/node-oracledb/doc/api.html#propconnmodule carefully doesn't mention anything about undefined.

It seems you are showing the Typescript definition from https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/oracledb. Can you open an issue there and ping @dannyb648? I also see @sla100 has made some contributions.

stale[bot] commented 2 years ago

This issue has been automatically marked as inactive because it has not been updated recently. It will be closed if no further activity occurs. Thank you for your contributions.

cjbj commented 2 years ago

Closing. As mentioned, this should be reported about the typescript definition file.