Remark about sorting with pagination

oracle / node-oracledb

Oracle Database driver for Node.js maintained by Oracle Corp.

http://oracle.github.io/node-oracledb/

Other

2.26k stars 1.07k forks source link

Remark about sorting with pagination #1508

Closed sla100 closed 2 years ago

sla100 commented 2 years ago

Signed-off-by: Your Name Sławomir Osoba <sla100@poczta.fm>

oracle-contributor-agreement[bot] commented 2 years ago

Oracle requires that contributors to all of its open-source projects sign the Oracle Contributor Agreement (OCA). The following contributors of this PR have not signed the OCA:

PR author: @sla100

In order to sign the OCA, you need to create an Oracle account and sign the OCA in the Oracle's Contributor Agreement Application by following the steps on the homepage.

When singing the OCA, please provide your GitHub username. By doing so, this PR will be automatically updated once the signed OCA was approved by Oracle.

cjbj commented 2 years ago

@sla100 did you use the same email address that you have recorded in the OCA app?

sla100 commented 2 years ago

Yes. It's same and has green status "Approved" on https://oca.opensource.oracle.com/

cjbj commented 2 years ago

Our GitHub team say that the OCA bot looks at the username you created the PR under and checks this in the OCA list - where you are listed as sosoba. They hint you should stick with the one email address & github username :)

Regardless, I've pulled this change into our internal repo and it will come back to GitHub soon. Thank you!