oracle / node-oracledb

Oracle Database driver for Node.js maintained by Oracle Corp.
http://oracle.github.io/node-oracledb/
Other
2.25k stars 1.07k forks source link

feature: Update oracledb.js for additional binary path #1602

Closed lemankk closed 11 months ago

lemankk commented 1 year ago

Hello, this PR is used for create additional parameter binaryPath when using initOracleClient(). It's open the way to load oracledb.node from different path of inside the default node_modules folder.

Usage:

initOracleClient({ binaryPath: '/path/to/folder-of-storing-oracledb.node' })
oracle-contributor-agreement[bot] commented 1 year ago

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA). The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

cjbj commented 1 year ago

@lemankk please sign the OCA before submitting PRs. Thanks!

oracle-contributor-agreement[bot] commented 1 year ago

Thank you for signing the OCA.

sharadraju commented 1 year ago

We are working on adding this feature internally with more comprehensive testing and will update you soon.

sharadraju commented 1 year ago

@lemankk This PR is now available as a patch in this GitHub repo. Please take the latest version of the file /lib/oracledb.js We have added a new property binaryDir for the initOracleClient() method to add the additional binary path.

It will added officially in the node-oracledb 6.2 release. Thank you for your contribution!

I will close this PR once 6.2 is out.

sharadraju commented 11 months ago

Closing this PR as this enhancement has been added in node-oracledb 6.2. Thank you for your contribution!