oracle / nosql-java-sdk

SDK for Java for the Oracle NoSQL Database
https://www.oracle.com/database/nosql/
Universal Permissive License v1.0
24 stars 24 forks source link

Added code to read proxy and KV versions from response headers. #12

Closed connelly38 closed 2 years ago

connelly38 commented 2 years ago

Updated several tests to be properly skipped if they are run with proxy/kv versions that do not support the tested feature. Cleaned up a few eclipse warnings.

connelly38 commented 2 years ago

Assuming you change (or not) according to specific comments this looks good. I expected that you might expose the versions via public interface (in Result). That should be part B unless you can think of a reason to keep it internal

Yes, this would be the logical next step if we decide to make the values public. I'm not sure there's a need for that yet.