search

oracle / nosql-java-sdk

SDK for Java for the Oracle NoSQL Database
https://www.oracle.com/database/nosql/
Universal Permissive License v1.0
24 stars 24 forks source link

Fix retry stats for queries #21

Closed connelly38 closed 2 years ago

connelly38 commented 2 years ago

Changed the query logic to copy various fields (retryStats, rate limiters, etc) back to the original request after processing. The original logic already made a copy of the request before processing it; this change just makes sure to copy back any fields that may have changed.

gmfeinberg commented 2 years ago

Is there a test that verifies this does what you want and fixes the missing stats?

Also the new fields that are copied are part of Request so why not create a couple of methods in Request to copy those vs exposing the fields and doing it in QueryRequest?

connelly38 commented 2 years ago

There isn't a test yet. I'll create one. I found this while testing other things in rate limiting.

I'll look at changing the logic to use a Request method.