search

oracle / oci-cloud-controller-manager

Kubernetes Cloud Controller Manager implementation for Oracle Cloud Infrastructure
Apache License 2.0
135 stars 84 forks source link

Tag resources created in OCI #107

Closed owainlewis closed 2 years ago

owainlewis commented 6 years ago

We could make use of resource tagging in OCI to track which resources are created by the CCM.

See: https://docs.us-phoenix-1.oraclecloud.com/Content/Identity/Concepts/taggingoverview.htm

jhorwit2 commented 6 years ago

@owainlewis this is blocked on the new go client AFAIK.

owainlewis commented 6 years ago

@jhorwit2 yeah we will need to wait until the new SDK ships for this one.

prydie commented 6 years ago

This is blocked by LBaaS not supporting tags. When LBaaS supports tags and the Go SDK has been updated we should also support adding addition tags via an annotation akin to what AWS does:

// ServiceAnnotationLoadBalancerAdditionalTags is the annotation used on the service
// to specify a comma-separated list of key-value pairs which will be recorded as
// additional tags in the ELB.
// For example: "Key1=Val1,Key2=Val2,KeyNoVal1=,KeyNoVal2"
const ServiceAnnotationLoadBalancerAdditionalTags = "service.beta.kubernetes.io/aws-load-balancer-additional-resource-tags"
jhorwit2 commented 6 years ago

https://docs.cloud.oracle.com/iaas/releasenotes/changes/9ced7d70-005a-4aa1-a47a-213dd8d2dcad/

This is now supported but blocked by https://github.com/oracle/oci-go-sdk/issues/118. We should also tag the load balancers with the cluster like kubernetes.io/cluster/<name> = owned as a freeform tag.

prydie commented 6 years ago

@owainlewis We probably want to prioritise this now its unblocked.

I suggest we start by adding support for tagging via an service.beta.kubernetes.io/oci-load-balancer-additional-resource-tags annotation.