Closed tobmad closed 4 months ago
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA). The following contributors of this PR have not signed the OCA:
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.
When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.
If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.
Thank you for signing the OCA.
Since this fix is already part of the internal oracle repo, the commit from internal repo will be cherry picked and updated in the upcoming release. Thanks for raising the PR, however you can close it now.
Since this fix is already part of the internal oracle repo, the commit from internal repo will be cherry picked and updated in the upcoming release. Thanks for raising the PR, however you can close it now.
Can I ask why this was never reviewed in my PR, but instead copied one-to-one to your internal repo? Resulting in me not being added as a contributer
This MR solves https://github.com/oracle/oci-cloud-controller-manager/issues/466, where if there is no change in the volume size, then
CapacityBytes
would be in GiB instead of Bytes.This bug makes resizing PVCs unreliable, as
ControllerExpandVolume
can be called multiple times, so in case the PVC has already been expanded it breaks.