search

oracle / oci-dotnet-sdk

Oracle Cloud Infrastructure SDK for .NET
https://cloud.oracle.com/cloud-infrastructure
Other
53 stars 20 forks source link

Fix incorrect escaping of URL parameters. #246

Closed mr-russ closed 1 month ago

mr-russ commented 2 months ago

We are escaping data elements as part of the Query parameter escaping. So use EscapeDataString, which is for that purpose.

See: https://stackoverflow.com/questions/4396598/whats-the-difference-between-escapeuristring-and-escapedatastring

For a discussion on the implications.

oracle-contributor-agreement[bot] commented 2 months ago

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA). The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

github-anurag commented 2 months ago

@mr-russ Thank you for your contribution. We will go through this and will incorporate it if this is needed. In the meanwhile, can you please sign the OCA agreement, needed for merging this pull request?

mr-russ commented 2 months ago

@github-anurag that was signed yesterday with 30 minutes of the request. There must be something inside Oracle holding it up. What can I do to resolve that?

mr-russ commented 2 months ago

@github-anurag I'm currently unable to migrate to Oracle Storage as our prefixes contain the # character. The incorrect escaping mean that we can't list objects. There may be other implication, but I can't verify those as attempting to get file lists fails.

github-anurag commented 1 month ago

@mr-russ These are the instructions that I see for signing the OCA:-

The following contributors of this PR have not signed the OCA:

PR author: mr-russ russell.smith@cornerstonesolutions.com.au (@mr-russ) To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

Can you check if you created the Oracle account with the same email account?

Djelibeybi commented 1 month ago

@mr-russ the email address you signed the OCA with doesn't match the email address in the PR, which is why this is not being passed by the OCA bot. Can you please either modify your PR to be submitted by the same email address as your signed OCA or perhaps add your email address to your Oracle account?

mr-russ commented 1 month ago

github did not choose my primary email. there is no way to "update" a pull request. I will be probably opening multiple pull requests while adjusting my profile to get it in the "right" state. That may however create issues in the future. Email addresses change, my account does not. But I'll see what I can do.

mr-russ commented 1 month ago

PR #248 was my next attempt, but it still shows an email that is no longer on my account and that I don't have access to.