oracle / oci-native-ingress-controller

OCI Native Ingress Controller
https://blogs.oracle.com/cloud-infrastructure/post/oracle-cloud-native-ingress-controller-kubernetes
Universal Permissive License v1.0
19 stars 21 forks source link

oke-30296-fix-multi-nodeport-bug #52

Closed Inbaraj-S closed 4 months ago

Inbaraj-S commented 6 months ago

In scenarios, in Flannel cni cluster with Service having multiple nodeports assigned, Native ingress controller is picking the first nodeport instead of picking the targetport based on the port in the ingress.

Fix: We fetch nodeport from the respective service definition.

coveralls commented 6 months ago

Pull Request Test Coverage Report for Build 8543739403

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/backend/backend.go 3 5 60.0%
pkg/controllers/nodeBackend/nodeBackend.go 5 7 71.43%
pkg/util/util.go 11 33 33.33%
<!-- Total: 19 45 42.22% -->
Files with Coverage Reduction New Missed Lines %
pkg/util/util.go 1 53.85%
pkg/controllers/nodeBackend/nodeBackend.go 1 65.98%
<!-- Total: 2 -->
Totals Coverage Status
Change from base Build 8448533111: 0.05%
Covered Lines: 2269
Relevant Lines: 3468

💛 - Coveralls