search

oracle / oci-php-sdk

Other
10 stars 7 forks source link

(fix): Required parameter follows optional parameter #11

Open markharding opened 1 year ago

markharding commented 1 year ago

PHP >=8.0 delivers a deprecation warning: PHP Deprecated: Required parameter $paramName follows optional parameter $params. Looking at the orNull function, there is always a value passed through for $params, so this should be a safe change to make required.

oracle-contributor-agreement[bot] commented 1 year ago

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA). The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.