search

oracle / oci-typescript-sdk

Oracle Cloud Infrastructure SDK for TypeScript and JavaScript
https://docs.oracle.com/en-us/iaas/Content/API/SDKDocs/typescriptsdk.htm
Other
68 stars 50 forks source link

calling toLowerCase on a number throws an exception #248

Open mmacmillan opened 8 months ago

mmacmillan commented 8 months ago

serviceCode is being parsed as a number and throwing the exception 'toLowerCase is not a function'; this exception hides the original exception being handled. coercing to a string and calling toLowerCase to handle null, numeric, and blank case

oracle-contributor-agreement[bot] commented 8 months ago

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA). The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

jyotisaini commented 6 months ago

@KalpanaRamasamy90 Can you take a look at the PR ?