oracle / oci-typescript-sdk

Oracle Cloud Infrastructure SDK for TypeScript and JavaScript
https://docs.oracle.com/en-us/iaas/Content/API/SDKDocs/typescriptsdk.htm
Other
73 stars 51 forks source link

[oci-common] Move node-fetch from devDependencies to dependencies #313

Open max-tremblay opened 1 month ago

max-tremblay commented 1 month ago

We encountered this issue on our side:

Error: Cannot find module 'node-fetch'
Require stack:
- node_modules/oci-common/lib/auth/url-based-x509-certificate-supplier.js
- node_modules/oci-common/lib/auth/abstract-federation-client-authenticated-details-provider-builder.js
- node_modules/oci-common/lib/auth/instance-principals-authentication-detail-provider.js
- node_modules/oci-common/lib/auth/helpers/delegate-auth-provider.js
- node_modules/oci-common/lib/signer.js
- node_modules/oci-common/index.js

This is required by oci-typescript-sdk/lib/common/lib/auth/url-based-x509-certificate-supplier.ts

/**
 * Copyright (c) 2020, 2021 Oracle and/or its affiliates.  All rights reserved.
 * This software is dual-licensed to you under the Universal Permissive License (UPL) 1.0 as shown at https://oss.oracle.com/licenses/upl or Apache License 2.0 as shown at http://www.apache.org/licenses/LICENSE-2.0. You may choose either license.
 */
import { parsePrivateKey, parseCertificate, Certificate, PrivateKey } from "sshpk";
import { FetchHttpClient } from "../http";
import X509CertificateSupplier from "./models/X509-certificate-supplier";
import CertificateAndPrivateKeyPair from "./certificate-and-privatekey-pair";
import Refreshable from "./models/refreshable";
import { getStringFromResponseBody } from "../helper";
import CircuitBreaker from "../circuit-breaker";
import fetch, { Response } from "node-fetch";