Patch to set the content_type implicitly or explicitly while uploadin…

oracle / ocifs

ocifs provides a POSIX-compatible API wrapping Oracle Cloud Infrastructure's (OCI) Object Storage. ocifs is a python library that relies on the fsspec framework.

https://ocifs.readthedocs.io/en/latest/

Universal Permissive License v1.0

17 stars 9 forks source link

Patch to set the content_type implicitly or explicitly while uploadin… #29

Closed dipatidar closed 11 months ago

dipatidar commented 11 months ago

path in reference to #28. Patch to set the content_type implicitly or explicitly while uploading content.

darenr commented 11 months ago

once you've added the tests can you post the screenshots showing both implicit and explicit results for some file types (one good one to use is README.md since mimetypes doesn't have a value for this (resulting in your [0] picking None)

darenr commented 11 months ago

this looks good, I did notice the precommit hooks were not running - if you run pre-commit install and commit the result then this looks good unless @ahosler sees anything that he has a concern about.

ahosler commented 11 months ago

Unit tests passed 👍